Allow the built tag to be prefixed with docker- which can be used to … #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rebuild images without Zipkin server
| - /^[0-9]/ | ||
| # Don't build docker- tags with Travis. Docker Hub will pick up and run the build. docker- tags are used to recreate | ||
| # docker images without rebuilding Zipkin so we don't need to run here. | ||
| - /^docker-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rebuild images without Zipkin server. Docker Hub will autobuild the
docker-*tags. When rebuilding a Docker image for a given Zipkin version, can just retag with the samedocker-Also combine
post_buildintobuild-post_buildis only really helpful when using Docker Hub's defaultbuildscript but since we override, may as well have one file.